Skip to content

Finish removal of Organization short name - Part 1#5186

Merged
cielf merged 9 commits into
rubyforgood:mainfrom
jp524:5167-remove-org-short-name
May 10, 2025
Merged

Finish removal of Organization short name - Part 1#5186
cielf merged 9 commits into
rubyforgood:mainfrom
jp524:5167-remove-org-short-name

Conversation

@jp524
Copy link
Copy Markdown
Contributor

@jp524 jp524 commented May 4, 2025

Related to #5167

Description

I removed the organization's short name from URLs last year in #4331. We now want to remove the column from the Organization table and ensure that everything still works.

This PR is best reviewed commit by commit.

Checklist from issue:

  • it looks like current_organization uses short_name. Figure out a way around that.
    -> I introduced the param organization_id where required
  • Remove short name from the admin and bank views of the organization, and the admin edit
  • Anything else that is revealed with a search for short name (anywhere we use short_name, we should be able to engineer to use id instead)
    -> There were quite a few spots were organization_name was used but no longer required. I cleaned that up as well
  • write a migration to drop the short_name from organization
    -> Removing a column requires the migration needs to be to done in multiple steps based on the Strong Migrations docs. I've done the first step (ignoring the column) in this PR. Finish removal of Organization short name - Part 2 #5187 contains the migration and can only be ran after this PR has been deployed
  • all tests addressed for the changes
  • check if the user guide mentions short name (as opposed to short_name for the rest of the code). If it does, make the appropiate adjustments.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Documentation update

How Has This Been Tested?

Modified existing specs and ensured that they passed.

Screenshots

n/a

@cielf
Copy link
Copy Markdown
Collaborator

cielf commented May 5, 2025

@dorner -- I think this one is mostly in your wheelhouse -- I'll need to do a sanity check once you've ok'd it just to make sure I cant break the current organization stuff.

@cielf cielf requested a review from dorner May 5, 2025 18:31
Copy link
Copy Markdown
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing - thank you so much for the tedious work on this one!

@dorner
Copy link
Copy Markdown
Collaborator

dorner commented May 9, 2025

@cielf feel free to merge at will.

@cielf
Copy link
Copy Markdown
Collaborator

cielf commented May 10, 2025

Sanity check completed -- Not exhausitive, but I'm pretty confident.

@cielf cielf merged commit 347529e into rubyforgood:main May 10, 2025
12 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

@jp524: Your PR Finish removal of Organization short name - Part 1 is part of today's Human Essentials production release: 2025.05.11.
Thank you very much for your contribution!

@jp524 jp524 deleted the 5167-remove-org-short-name branch May 23, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants